Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ocsf): Add compliance #3753

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix(ocsf): Add compliance #3753

merged 2 commits into from
Apr 12, 2024

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Apr 11, 2024

Context

In the native JSON in v3 we had a Compliance key to store frameworks and requirements. We need that for the JSON OCSF.

Fixes #3742

Description

Add a unmapped.compliance in the Detection Finding.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team as a code owner April 11, 2024 06:24
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.77%. Comparing base (571f3eb) to head (8575660).

Files Patch % Lines
prowler/lib/outputs/outputs.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3753      +/-   ##
==========================================
- Coverage   85.77%   85.77%   -0.01%     
==========================================
  Files         722      722              
  Lines       22464    22465       +1     
==========================================
  Hits        19269    19269              
- Misses       3195     3196       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔝

@pedrooot pedrooot merged commit 54c309d into master Apr 12, 2024
10 of 12 checks passed
@pedrooot pedrooot deleted the add-compliance-to-ocsf branch April 12, 2024 10:28
sergargar pushed a commit that referenced this pull request Apr 15, 2024
Co-authored-by: pedrooot <pedromarting3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Output formats for JSON, HTML not accepted
2 participants