Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wafv2): Handle WAFNonexistentItemException #3761

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

pedrooot
Copy link
Member

Description

Handle WAFNonexistentItemException for wafv2 service in get_logging_configuration

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team April 12, 2024 09:09
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.77%. Comparing base (e9117f9) to head (7dfa53f).

Files Patch % Lines
...wler/providers/aws/services/wafv2/wafv2_service.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3761      +/-   ##
==========================================
+ Coverage   85.73%   85.77%   +0.04%     
==========================================
  Files         722      722              
  Lines       22464    22469       +5     
==========================================
+ Hits        19259    19273      +14     
+ Misses       3205     3196       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@jfagoagas jfagoagas merged commit a289a80 into master Apr 12, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the handle-waf-exception branch April 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants