fix(dashboard): fix error in windows for csvreader #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3806 +/- ##
==========================================
+ Coverage 85.51% 85.53% +0.02%
==========================================
Files 731 731
Lines 22659 22661 +2
==========================================
+ Hits 19376 19384 +8
+ Misses 3283 3277 -6 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Apr 17, 2024
dashboard/pages/compliance.py
Outdated
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| csv_files = [] | |||
| for file in glob.glob(os.path.join(folder_path_compliance, "*.csv")): | |||
| with open(file, "r", newline="") as csvfile: | |||
| with open(file, "r", newline="", encoding="utf-8") as csvfile: | |||
There was a problem hiding this comment.
Can you add the encoding in the config and the use it here? The same for the other file.
There was a problem hiding this comment.
Good catch, I´ve already done it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3766
Description
Windows was having some problems with the encoding from csv files, adding
encoding="utf-8"when a csv file is opened fixes it.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.