Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ocsf): Add resource details to data #3819

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Apr 19, 2024

Context

Fixes #3788

Description

Add resource details to ResourceDetails[].data in the OCSF output.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners April 19, 2024 05:57
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

n4ch04
n4ch04 previously approved these changes Apr 19, 2024
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (e192a98) to head (b8da636).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
+ Coverage   85.44%   85.45%   +0.01%     
==========================================
  Files         737      737              
  Lines       22810    22811       +1     
==========================================
+ Hits        19490    19494       +4     
+ Misses       3320     3317       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas merged commit e4652d4 into master Apr 19, 2024
12 checks passed
@jfagoagas jfagoagas deleted the add-resource-details-ocsf branch April 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prowler v4 Output Format Change
2 participants