Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gcp): handle list projects API call errors #3849

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

sergargar
Copy link
Member

Description

Handle list projects API call errors so we do not print a default error always.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested review from a team April 24, 2024 09:28
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.49%. Comparing base (69d4f55) to head (20caf41).
Report is 9 commits behind head on master.

Files Patch % Lines
prowler/providers/gcp/gcp_provider.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3849    +/-   ##
========================================
  Coverage   85.49%   85.49%            
========================================
  Files         737      741     +4     
  Lines       22779    22895   +116     
========================================
+ Hits        19474    19574   +100     
- Misses       3305     3321    +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

prowler/providers/gcp/gcp_provider.py Outdated Show resolved Hide resolved
prowler/providers/gcp/gcp_provider.py Outdated Show resolved Hide resolved
Co-authored-by: Pepe Fagoaga <pepe@prowler.com>
jfagoagas
jfagoagas previously approved these changes Apr 25, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks @sergargar

@jfagoagas jfagoagas merged commit 721f73f into master Apr 29, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the handle-get-projects-gcp branch April 29, 2024 09:32
sergargar added a commit that referenced this pull request May 3, 2024
Co-authored-by: Pepe Fagoaga <pepe@prowler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants