fix(efs): check all public conditions #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3872 +/- ##
==========================================
+ Coverage 86.33% 86.39% +0.05%
==========================================
Files 746 747 +1
Lines 23228 23246 +18
==========================================
+ Hits 20055 20083 +28
+ Misses 3173 3163 -10 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Great improvement @sergargar 👏
I left some comments about code organisation and some things missing in tests.
prowler/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible.py
Outdated
Show resolved
Hide resolved
| and conditions["Bool"].get("elasticfilesystem:AccessedViaMountTarget") | ||
| == "true" | ||
| ): | ||
| return True |
There was a problem hiding this comment.
It'd be more readable to set a has_secure_conditions = False by default and the here
Suggested change
| return True | |
| has_secure_conditions = True |
prowler/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible.py
Outdated
Show resolved
Hide resolved
prowler/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible.py
Outdated
Show resolved
Hide resolved
...s/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible_test.py
Outdated
Show resolved
Hide resolved
...s/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible_test.py
Show resolved
Hide resolved
...s/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible_test.py
Outdated
Show resolved
Hide resolved
...s/providers/aws/services/efs/efs_not_publicly_accessible/efs_not_publicly_accessible_test.py
Show resolved
Hide resolved
jfagoagas
approved these changes
Apr 30, 2024
jfagoagas
deleted the
3865-bug-efs_not_publicly_accessible-does-not-consider-recommended-aws-condition-1
branch
sergargar
added a commit
that referenced
this pull request
May 3, 2024
sergargar
added
backport-v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in https://docs.aws.amazon.com/efs/latest/ug/access-control-block-public-access.html#what-is-a-public-policy, check all the possible conditions that could make an EFS volume public.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.