chore(aws): cleanup aws test cases #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4049 +/- ##
==========================================
- Coverage 86.34% 86.25% -0.10%
==========================================
Files 778 778
Lines 24368 24368
==========================================
- Hits 21041 21018 -23
- Misses 3327 3350 +23 ☔ View full report in Codecov by Sentry. |
jfagoagas
reviewed
May 21, 2024
There was a problem hiding this comment.
Many thanks @madereddy for taking care of the tests removing the search 👏
I left just one question about a change in one status_extended.
There was a problem hiding this comment.
Currently the report status extended sends the topic arn. To keep it consistent it should be switched to topic name. The topic arn is still reported.
jfagoagas
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Clean up AWS test cases to meet prowler standards.
Description
Fix SNS Topic check for KMS at rest by replacing SNS Topic arn with SNS Topic Name for report.status_extended.
Fix Workspaces encrypted volume check to remove the double negative when root and user data volumes are encrypted.
Cleanup AWS test cases to remove assert search for SageMaker, SNS, SQS, Well Architected, and Workspaces.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.