Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws): cleanup aws test cases and standardize checks #4053

Merged
merged 1 commit into from
May 21, 2024

Conversation

madereddy
Copy link
Contributor

Context

Clean up AWS test cases to meet prowler standards.

Description

Fix Redshift checks to report back the cluster id instead of cluster ARN.

Fix Organization checks to standardize starting with "AWS Organizations {org.id} as different checks within Organization had different starting points.

Fix S3 check to standardize start with S3 Bucket {bucket.name} and cleanup verbiage.

Cleanup AWS test cases to remove assert search for Redshift, Organizations, and S3.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@madereddy madereddy requested review from a team May 21, 2024 14:32
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 21, 2024
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @madereddy !

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.27%. Comparing base (716d388) to head (e8627f6).
Report is 3 commits behind head on master.

Files Patch % Lines
...ny_regions/organizations_scp_check_deny_regions.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4053      +/-   ##
==========================================
- Coverage   86.34%   86.27%   -0.08%     
==========================================
  Files         783      783              
  Lines       24537    24562      +25     
==========================================
+ Hits        21187    21190       +3     
- Misses       3350     3372      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 9e934b8 into prowler-cloud:master May 21, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants