Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): mapping of extra748 and add extra74 #4059

Merged
merged 1 commit into from
May 22, 2024

Conversation

kagahd
Copy link
Contributor

@kagahd kagahd commented May 22, 2024

Context

The mapping documentation needs an update.

Description

I fixed the mapping of extra748 which was wrongly mapped to ec2_securitygroup_allow_ingress_from_internet_to_any_port but should have be mapped to ec2_securitygroup_allow_ingress_from_internet_to_all_ports.

Furthermore, the check ec2_securitygroup_allow_ingress_from_internet_to_any_port was added in PR #3962. Therefore I added the mapping from ec2_securitygroup_allow_ingress_from_internet_to_any_port to extra74

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kagahd kagahd requested review from a team as code owners May 22, 2024 13:01
@jfagoagas jfagoagas changed the title fix(doc) mapping of extra748 and add extra74 fix(doc): mapping of extra748 and add extra74 May 22, 2024
@jfagoagas jfagoagas requested a review from sergargar May 22, 2024 13:12
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label May 22, 2024
@sergargar sergargar merged commit d007555 into prowler-cloud:master May 22, 2024
9 of 10 checks passed
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants