chore(CLI): start working on CLI #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…golo-com-and-set-a-base-project
jfagoagas
requested changes
May 23, 2024
There was a problem hiding this comment.
Add an __init__.py file in this folder please.
cli/cli.py
Outdated
Comment on lines
23
to
27
| total = 0 | ||
| for value in track(range(100), description="Processing..."): | ||
| time.sleep(0.01) | ||
| total += 1 | ||
| if show: |
There was a problem hiding this comment.
Not really, it's to show the status bar
pyproject.toml
Outdated
| optional = true | ||
|
|
||
| [tool.poetry.group.cli.dependencies] | ||
| typer = "^0.12.3" |
There was a problem hiding this comment.
Suggested change
| typer = "^0.12.3" | |
| typer = "0.12.3" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4067 +/- ##
==========================================
+ Coverage 86.26% 86.35% +0.09%
==========================================
Files 790 790
Lines 24729 24728 -1
==========================================
+ Hits 21333 21355 +22
+ Misses 3396 3373 -23 ☔ View full report in Codecov by Sentry. |
…golo-com-and-set-a-base-project
jfagoagas
requested changes
May 24, 2024
cli/cli.py
Outdated
Comment on lines
17
to
42
| @aws.command( | ||
| "list-services", help="List the AWS services that are supported by Prowler." | ||
| ) | ||
| def list_services_aws(): | ||
| print_services(list_services("aws")) | ||
|
|
||
|
|
||
| @azure.command( | ||
| "list-services", help="List the Azure services that are supported by Prowler." | ||
| ) | ||
| def list_services_azure(): | ||
| print_services(list_services("azure")) | ||
|
|
||
|
|
||
| @gcp.command( | ||
| "list-services", help="List the GCP services that are supported by Prowler." | ||
| ) | ||
| def list_services_gcp(): | ||
| print_services(list_services("gcp")) | ||
|
|
||
|
|
||
| @kubernetes.command( | ||
| "list-services", help="List the Kubernetes services that are supported by Prowler." | ||
| ) | ||
| def list_services_kubernetes(): | ||
| print_services(list_services("kubernetes")) |
There was a problem hiding this comment.
Is there any way to make this a generic command for all the providers in typer?
jfagoagas
reviewed
May 24, 2024
| def create_list_commands(provider_typer: typer.Typer, provider_name: str): | ||
| @provider_typer.command( | ||
| "list-services", | ||
| help=f"List the {provider_name} services that are supported by Prowler.", |
There was a problem hiding this comment.
Can you get the provider_name from typer.Typer?
pedrooot
deleted the
PRWLR-3741-research-about-https-typer-tiangolo-com-and-set-a-base-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR new CLI it's added, I'll be improving this but at the momment It just list services and shows the banner.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.