feat(AWS): New Storage Gateway FileShare KMS CMK Check #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4082 +/- ##
==========================================
+ Coverage 86.26% 86.30% +0.03%
==========================================
Files 790 793 +3
Lines 24729 24803 +74
==========================================
+ Hits 21333 21406 +73
- Misses 3396 3397 +1 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
May 24, 2024
prowler/providers/aws/services/storagegateway/storagegateway_service.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
May 24, 2024
prowler/providers/aws/services/storagegateway/storagegateway_service.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
May 24, 2024
prowler/providers/aws/services/storagegateway/storagegateway_service.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
May 24, 2024
prowler/providers/aws/services/storagegateway/storagegateway_service.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
May 24, 2024
| file_share_arn: str | ||
| gateway_arn: str | ||
| region: str | ||
| file_share_type: str |
There was a problem hiding this comment.
Suggested change
| file_share_type: str | |
| _type: str |
There was a problem hiding this comment.
_type caused some errors so changed it to fs_type and that worked. Hopefully that solves comment.
sergargar
requested changes
May 24, 2024
sergargar
reviewed
May 24, 2024
prowler/providers/aws/services/storagegateway/storagegateway_service.py
Outdated
Show resolved
Hide resolved
sergargar
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add Storage Gateway Service with FileShare KMS CMK check
Description
Default Storage Gateway FileShares uses default keys instead of KMS CMK which does not have fine grained control.
Added Storage Gateway Service and Test checks to support this additional service.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.