Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): ParameterValue MySQL and MariaDB RDS Instances #4116

Merged
merged 1 commit into from
May 28, 2024

Conversation

sansns
Copy link
Contributor

@sansns sansns commented May 28, 2024

Context

MySQL and MariaDB Instances use a require_secure_transport = 1 while the clusters use require_secure_transport = ON to set the ParameterValue for requiring encryption.

Description

The current checks have been updated for DB Instances to check for require_secure_transport = ON which will not provide the correct information.

RDS MySQL Cluster Encryption Required

RDS MySQL DB Instance Encryption Required

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sansns sansns requested review from a team as code owners May 28, 2024 13:55
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a029296) to head (1507e2f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4116      +/-   ##
==========================================
- Coverage   86.40%   86.33%   -0.08%     
==========================================
  Files         794      794              
  Lines       24874    24874              
==========================================
- Hits        21493    21474      -19     
- Misses       3381     3400      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you @sansns !!

@sergargar sergargar merged commit 38c9187 into prowler-cloud:master May 28, 2024
10 of 11 checks passed
@sergargar sergargar added backport-v3 Pending to port to Prowler v3 branch and removed backport-v3 Pending to port to Prowler v3 branch labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants