Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mutelist): Handle items starting by * #4136

Conversation

jfagoagas
Copy link
Member

Context

We are aborting the execution if the allowlist regex fails unexpectedly and also not handling right when the pattern starts by * which is not a valid regex.

Description

  • Change critical log to error
  • Return False if something not handled happens.
  • If the pattern starts by * add a . in front of it.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners May 30, 2024 12:34
@jfagoagas jfagoagas changed the title fix(allowlist): Handle items starting by * fix(mutelist): Handle items starting by * May 30, 2024
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (52955f9) to head (139b23e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4136      +/-   ##
==========================================
- Coverage   86.66%   86.64%   -0.02%     
==========================================
  Files         815      815              
  Lines       25468    25468              
==========================================
- Hits        22071    22067       -4     
- Misses       3397     3401       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas merged commit a51bdef into master May 30, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-3825-debug-scanner-issue-error-nothing-to-repeat-at-position-0-v4 branch May 30, 2024 13:04
sansns pushed a commit to sansns/prowler that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants