-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rds): Handle DBParameterGroupNotFound #4148
fix(rds): Handle DBParameterGroupNotFound #4148
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4148 +/- ##
==========================================
- Coverage 86.71% 86.60% -0.11%
==========================================
Files 815 815
Lines 25476 25492 +16
==========================================
- Hits 22091 22077 -14
- Misses 3385 3415 +30 ☔ View full report in Codecov by Sentry. |
regional_client.get_paginator( | ||
"describe_db_parameters" | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put another try before this for loop (which is the one that is failing), so even if the cluster does not have parameter group name, its class can be created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removing backport-v3 tag in favor of the new PR of this issue #4150 |
Description
Handle
DBParameterGroupNotFound
when callingdescribe_db_parameters
RDS API.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.