Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trustedadvisor): handle AccessDenied exception #4158

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sergargar
Copy link
Member

Context

When running prowler, if there is an access denied when describing AWS Support services, the trusted advisor checks would not be completed.

Description

Handle the Access Denied exception so the Trusted Advisor check can be executed.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested review from a team as code owners June 3, 2024 17:18
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Jun 3, 2024
@sergargar sergargar linked an issue Jun 3, 2024 that may be closed by this pull request
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (b33b529) to head (58b9376).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4158   +/-   ##
=======================================
  Coverage   86.68%   86.68%           
=======================================
  Files         817      817           
  Lines       25564    25564           
=======================================
+ Hits        22159    22161    +2     
+ Misses       3405     3403    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 0c01cf2 into master Jun 3, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-3857-solve-trusted-advisor-issue branch June 3, 2024 19:15
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Trusted Advisor checks does not complete when access is denied
2 participants