Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(run_check): Simplify and add tests #4183

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

jfagoagas
Copy link
Member

Description

  • Simplify and add tests for the run_check function.
  • Remove a sys.exit() while getting the check's compliance dict and return {} if some exception is raised.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners June 4, 2024 12:45
@jfagoagas jfagoagas self-assigned this Jun 4, 2024
@jfagoagas jfagoagas changed the title Prwlr 3873 simplify run check and add tests refactor(run_check): Simplify and add tests Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.67%. Comparing base (8d4abd7) to head (9389f99).
Report is 1 commits behind head on master.

Files Patch % Lines
prowler/lib/check/check.py 60.00% 2 Missing ⚠️
prowler/lib/outputs/compliance/compliance.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4183      +/-   ##
==========================================
+ Coverage   86.62%   86.67%   +0.04%     
==========================================
  Files         817      817              
  Lines       25578    25579       +1     
==========================================
+ Hits        22157    22170      +13     
+ Misses       3421     3409      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergargar sergargar merged commit 910c969 into master Jun 4, 2024
10 of 11 checks passed
@sergargar sergargar deleted the PRWLR-3873-simplify-run-check-and-add-tests branch June 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants