Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): check if account is signed up #4194

Conversation

sergargar
Copy link
Member

Description

Put a WARNING log if the account is not signed up to the S3 service.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested review from a team June 5, 2024 18:30
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (f3c6720) to head (5e9e23b).
Report is 1 commits behind head on master.

Files Patch % Lines
prowler/providers/aws/services/s3/s3_service.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
- Coverage   86.76%   86.68%   -0.08%     
==========================================
  Files         817      817              
  Lines       25599    25604       +5     
==========================================
- Hits        22211    22195      -16     
- Misses       3388     3409      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@sergargar sergargar merged commit 0de10c4 into master Jun 6, 2024
9 of 11 checks passed
@sergargar sergargar deleted the PRWLR-3870-handle-your-account-is-not-signed-up-for-the-s-3-service-you-must-sign-up-before-you-can-use-s-3 branch June 6, 2024 12:43
sergargar added a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants