fix(html): handle muted status to html outputs #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4195 +/- ##
==========================================
- Coverage 86.76% 86.66% -0.10%
==========================================
Files 817 818 +1
Lines 25599 25674 +75
==========================================
+ Hits 22211 22251 +40
- Misses 3388 3423 +35 ☔ View full report in Codecov by Sentry. |
|
Thanks @pedrooot! 💯 |
sergargar
reviewed
Jun 6, 2024
sergargar
reviewed
Jun 6, 2024
prowler/lib/outputs/html/html.py
Outdated
Comment on lines
146
to
147
| elif finding.status == "WARNING": | ||
| row_class = "table-warning" |
There was a problem hiding this comment.
This is no longer needed in v4
sergargar
reviewed
Jun 6, 2024
prowler/lib/outputs/html/html.py
Outdated
Comment on lines
148
to
149
| elif "Muted" in finding.status: | ||
| row_class = "table-secondary" |
There was a problem hiding this comment.
Suggested change
| elif "Muted" in finding.status: | |
| row_class = "table-secondary" |
sergargar
reviewed
Jun 6, 2024
sergargar
deleted the
PRWLR-3876-bug-unable-to-filter-muted-findings-in-html-output-4181
branch
sergargar
added a commit
that referenced
this pull request
Jun 6, 2024
Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
sergargar
added a commit
that referenced
this pull request
Jun 6, 2024
Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
sergargar
added a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #4181
Description
Muted FIndings appeared as Pass/Fail/Manual, it's necessary to handle the case when the finding it's muted on HTML outputs.
Thanks @alanrickman-keysight for the report 🥇
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.