Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): resolve html changing finding status #4199

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Jun 6, 2024

Description

Findings outputs where changing inside the fill_html function.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners June 6, 2024 14:50
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.69%. Comparing base (e6472f9) to head (ce2c0d1).

Files Patch % Lines
prowler/lib/outputs/html/html.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4199      +/-   ##
==========================================
- Coverage   86.74%   86.69%   -0.06%     
==========================================
  Files         818      818              
  Lines       25674    25674              
==========================================
- Hits        22271    22257      -14     
- Misses       3403     3417      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 0a41ec4 into master Jun 6, 2024
9 of 11 checks passed
@sergargar sergargar deleted the PRWLR-3896-muted-findings-on-html-outputs-modifying-finding-status branch June 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants