Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): fix status from HTML outputs #4206

Merged

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Jun 7, 2024

Description

Finding status were showing with a bad format on HTML outputs
Screenshot 2024-06-07 at 12 09 11

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners June 7, 2024 10:08
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.71%. Comparing base (28b9e26) to head (8ec7b14).

Files Patch % Lines
prowler/lib/outputs/html/html.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4206      +/-   ##
==========================================
+ Coverage   86.66%   86.71%   +0.04%     
==========================================
  Files         818      818              
  Lines       25674    25674              
==========================================
+ Hits        22251    22263      +12     
+ Misses       3423     3411      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sergargar sergargar merged commit 45ea9e1 into master Jun 7, 2024
10 of 11 checks passed
@sergargar sergargar deleted the PRWLR-3898-html-finfings-status-showing-with-bad-format branch June 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants