chore(acm): Improve near-expiration certificates check #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make configurable check and ignore unused certs
and fix old checks to include the in_use property in certs
github-actions
bot
added
documentation
provider/aws
sergargar
reviewed
Jun 7, 2024
sergargar
reviewed
Jun 7, 2024
sergargar
previously approved these changes
Jun 7, 2024
sergargar
approved these changes
Jun 7, 2024
sergargar
added a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Sergio <sergio@prowler.com>
sergargar
added a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Sergio <sergio@prowler.com>
sergargar
added a commit
that referenced
this pull request
Jul 1, 2024
Co-authored-by: Sergio <sergio@prowler.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Improve all the changes commented about near-expiration certificates check commented in #3966.
Description
Check modified to be configurable and ignore unused certs (added all of this changes to docs yet), modified the severity in function of the cert situation (near expiration -> medium and expired -> high) and unit test have been modified to cover most cases with this new features.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.