Fix BytesWarning when logging response status/content

[wdoekes]

Fixes the following, seen with Python 3.10.6:

  logger.debug(f"Status code: {resp.status_code}, output: {resp.content}")
proxmoxer/core.py:145: BytesWarning: str() on a bytes instance

[jhollowe]

What API call did you do to have this show up? Do you have a code snippet to reproduce the error this is fixing?

[wdoekes]

Apparently you need -b on the python command line to unhide the warning:

$ python3 -c 'b=b"";print(f"{b}")'
b''

vs.

$ python3 -b -c 'b=b"";print(f"{b}")'
<string>:1: BytesWarning: str() on a bytes instance
b''

or

$ PYTHONWARNINGS='default,default::BytesWarning,error::BytesWarning' python3 -b -c 'b=b"";print(f"{b}")'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
BytesWarning: str() on a bytes instance

or

$ python3 -bb -c 'b=b"";print(f"{b}")'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
BytesWarning: str() on a bytes instance

Without at least one -b you won't get the BytesWarnings. Not sure what the rationale is there.

[wdoekes]

So, I did some googling and came across this thread https://mail.python.org/archives/list/python-dev@python.org/thread/XBIZSPXCSH4KHPX7A6W7XB3H26LLNZQ4/ -- it discusses the removal of the -b functionality.

Not sure why that deprecation would be forced upon us, as the -b feature seems super useful to me:

$ python3 -b -c 'b=b"\xe2\x82\xac";c=b.decode();print(b=="€",c=="€")'
<string>:1: BytesWarning: Comparison between bytes and string
False True