Changes for use of proxy-wasm in envoy-wasm. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <jplevyak@gmail.com>
yxue
reviewed
Apr 6, 2020
proxy_wasm_api.h
Outdated
| size_t *new_size = nullptr) { | ||
| auto result = proxy_set_buffer_bytes(type, start, length, data.data(), data.size()); | ||
| if (result == WasmResult::Ok && new_size) | ||
| *new_size += -length + data.size(); |
There was a problem hiding this comment.
length or -length?
Will the - in front of the length generate a very large number?
There was a problem hiding this comment.
I should add a test. The amount in length is removed from the initial size. If length is > the initial size then result != WasmResult::Ok. So, this should be safe AFAICT.
yxue
approved these changes
Apr 6, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com