Support passing end_of_stream to header callbacks #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this in a backwardly-compatible way by creating two new ABI functions: on_request_headers_ext on_response_headers_ext Each one takes an additional Word parameter at the end which carries the value of the "end_of_stream" flag from Envoy. The proxy_wasm_cpp_host code will first check for the existence of the "ext" version of a function and fall back to the original version if it is not found. Signed-off-by: Gregory Brail <gregbrail@google.com>
jplevyak
approved these changes
May 28, 2020
jplevyak
suggested changes
May 28, 2020
|
That's fine -- thanks for the update. I'll update the PR and re-submit (and
submit a PR for the host code as well).
…On Thu, May 28, 2020 at 10:33 AM John Plevyak ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We do not yet have to be compatible. Let's just make a set of related
changes to the SDK and host support code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7I22ZZG2DMZJKTINYAPLRT2N7NANCNFSM4NHI7COQ>
.
|
|
I'll drop this in favor of a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this in a backwardly-compatible way by creating two new ABI
functions:
on_request_headers_ext
on_response_headers_ext
Each one takes an additional Word parameter at the end which
carries the value of the "end_of_stream" flag from Envoy.
The proxy_wasm_cpp_host code will first check for the existence
of the "ext" version of a function and fall back to the original
version if it is not found.
If you like this approach, then I'll submit the matching PR to fix this in the "host" repo.
If you would prefer to simply add the additional flag to the existing function signatures,
then I'm happy to do that as well. It would be an incompatible change to the ABI, although I think that one of those was already made when the function to get the configuration data was removed.
Signed-off-by: Gregory Brail gregbrail@google.com