New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit 4bac945fc78121277d3735ffb22ba83a64b91c16 to fix issue #57 is wrong #59
Comments
Fix released with proxytunnel v1.11.1 |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Oct 17, 2023
PR: 274521 Changes: https://github.com/proxytunnel/proxytunnel/blob/master/CHANGES Upstream issue: proxytunnel/proxytunnel#59, proxytunnel/proxytunnel#69 (cherry picked from commit e794a96)
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Oct 17, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 20, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 21, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 22, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 23, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 27, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 28, 2023
lsalvadore
pushed a commit
to lsalvadore/freebsd-ports
that referenced
this issue
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
commit 4bac945 to fix #57 is wrong and proxytunnel is broken since this commit. SSL_set_tlsext_host_name() returns 1 on success or 0 in case of an error. Error codes like SSL_TLSEXT_ERR_OK, SSL_TLSEXT_ERR_ALERT_FATAL, SSL_TLSEXT_ERR_ALERT_WARNING and SSL_TLSEXT_ERR_NOACK are returned by the underlaying function SSL_CTX_set_tlsext_servername_callback() but not from SSL_set_tlsext_host_name() itself. My proposal to fix the issue is:
The text was updated successfully, but these errors were encountered: