Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash in projectname crashes Piereling client code #83

Closed
hayco opened this issue Oct 23, 2019 · 1 comment
Closed

Dash in projectname crashes Piereling client code #83

hayco opened this issue Oct 23, 2019 · 1 comment
Assignees
Milestone

Comments

@hayco
Copy link

hayco commented Oct 23, 2019

clamclient.create() crashes when trying to create a project which contains a - character:

Generated projectname: clariah-conversion2546116374648037985
Traceback (most recent call last):
  File "./01-doc-to-folia.py", line 32, in <module>
    pier.create(project)
  File "/home/jong/.local/lib/python3.7/site-packages/clam/common/client.py", line 228, in create
    return self.request(project + '/', 'PUT')
  File "/home/jong/.local/lib/python3.7/site-packages/clam/common/client.py", line 164, in request
    if data.errors:
AttributeError: 'bool' object has no attribute 'errors'

Expected behaviour: either - is allowed and the project is succesfully created, or a message explaning what was wrong with project is displayed / returned.
The exception AttributeError: 'bool' object has no attribute 'errors' was not helpful.

@proycon proycon self-assigned this Oct 23, 2019
@proycon
Copy link
Owner

proycon commented Oct 23, 2019

Agreed, that's a weird and uninformative error. It's a CLAM issue indeed so I'll try to move this to that repo.

@proycon proycon transferred this issue from proycon/piereling Oct 23, 2019
@proycon proycon added the bug label Oct 23, 2019
@proycon proycon added this to the v2.5 milestone Oct 23, 2019
proycon added a commit that referenced this issue Oct 24, 2019
@proycon proycon added the ready label Oct 25, 2019
@proycon proycon closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants