Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: codemetapy fails to add orcids to all contributors listed in a package.json #45

Closed
apirogov opened this issue Aug 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working ready Done/implemented, but release still pending

Comments

@apirogov
Copy link

apirogov commented Aug 8, 2023

Input package.json:

{
  "name": "somesy",
  "version": "0.1.0",
  "description": "A cli tool for synchronizing CITATION.CFF with project files.",
  "keywords": [
    "metadata",
    "FAIR"
  ],
  "license": "MIT",
  "repository": {
    "type": "git",
    "url": "https://github.com/Materials-Data-Science-and-Informatics/somesy"
  },
  "homepage": "https://materials-data-science-and-informatics.github.io/somesy",
  "author": {
    "name": "Mustafa Soylu",
    "email": "m.soylu@fz-juelich.de",
    "url": "https://orcid.org/0000-0003-2637-0432"
  },
  "contributors": [
    {
      "name": "Mustafa Soylu",
      "email": "m.soylu@fz-juelich.de",
      "url": "https://orcid.org/0000-0003-2637-0432"
    },
    {
      "name": "Anton Pirogov",
      "email": "a.pirogov@fz-juelich.de",
      "url": "https://orcid.org/0000-0002-5077-7497"
    },
    {
      "name": "Jens Br\u00f6der",
      "email": "j.broeder@fz-juelich.de",
      "url": "https://orcid.org/0000-0001-7939-226X"
    }
  ],
  "main": "index.js",
  "scripts": {
    "test": "echo \"No tests available\""
  },
  "dependencies": {
    "lodash": "^4.17.21",
    "axios": "^0.21.1"
  },
  "devDependencies": {
    "jest": "^27.0.6"
  }
}

Resulting codemeta.json:

[...]
    "contributor": [
        {
            "@type": "Person",
            "email": "m.soylu@fz-juelich.de",
            "familyName": "Soylu",
            "givenName": "Mustafa",
            "url": "https://orcid.org/0000-0003-2637-0432"
        },
        {
            "@type": "Person",
            "email": "a.pirogov@fz-juelich.de",
            "familyName": "Pirogov",
            "givenName": "Anton"
        },
        {
            "@type": "Person",
            "email": "j.broeder@fz-juelich.de",
            "familyName": "Bröder",
            "givenName": "Jens"
        }
    ],
[...]

So the ORCID / Url is not preserved except for the first listed contributor.

@proycon
Copy link
Owner

proycon commented Sep 13, 2023

Sorry for the long delay (I was off for a while during the summer/holiday
period). This indeed looks like a clear bug in the package.json parsing, or
conversion afterwards. I will investigate further.

@proycon proycon self-assigned this Sep 13, 2023
@proycon proycon added the bug Something isn't working label Sep 13, 2023
@proycon proycon added the ready Done/implemented, but release still pending label Sep 13, 2023
@proycon
Copy link
Owner

proycon commented Sep 18, 2023

Fixed and released now

@proycon proycon closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready Done/implemented, but release still pending
Projects
None yet
Development

No branches or pull requests

2 participants