setup.py: fix installation under pip #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip installs pynlpl by invoking the setup.py without a fully specified path,
causing the chdir() invocation to fail with this message:
Downloading PyNLPl-0.6.5.1.tar.gz (121kB): 121kB downloaded
Running setup.py egg_info for package pynlpl
Traceback (most recent call last):
File "<string>", line 16, in <module>
File "/tmp/pip_build_bazsi/pynlpl/setup.py", line 11, in <module>
os.chdir(os.path.dirname(sys.argv[0]))
OSError: [Errno 2] No such file or directory: ''
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 16, in <module>
File "/tmp/pip_build_bazsi/pynlpl/setup.py", line 11, in <module>
os.chdir(os.path.dirname(sys.argv[0]))
The workaround is to tell pip not to clean up the sources and install
pynlpl manually. This fix solves the problem by not using
argv[0] that might lack a fully specified path, but rather using __file__,
that Python already fills nicely for us.
Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
proycon
added a commit
that referenced
this pull request
Apr 9, 2014
setup.py: fix installation under pip , use __file__ instead of sys.argv[0]
|
Thanks for your fix! |
|
I have pushed the fix to the Python Package Index as well now. |
|
great, thanks. This patch didn't solve all pip install problems though. I might have some followups, but great to know there's a responsive author. thanks for the great product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip installs pynlpl by invoking the setup.py without a fully specified path,
causing the chdir() invocation to fail with this message:
Downloading PyNLPl-0.6.5.1.tar.gz (121kB): 121kB downloaded
Running setup.py egg_info for package pynlpl
Traceback (most recent call last):
File "", line 16, in
File "/tmp/pip_build_bazsi/pynlpl/setup.py", line 11, in
os.chdir(os.path.dirname(sys.argv[0]))
OSError: [Errno 2] No such file or directory: ''
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 16, in
File "/tmp/pip_build_bazsi/pynlpl/setup.py", line 11, in
The workaround is to tell pip not to clean up the sources and install
pynlpl manually. This fix solves the problem by not using
argv[0] that might lack a fully specified path, but rather using file,
that Python already fills nicely for us.
Signed-off-by: Balazs Scheidler bazsi@balabit.hu