Removing Depricated APIs #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed depricated APIs: `UnityWebRequest.result.isNetworkError` and `UnityWebRequest.result.isHttpError` Replaced with : `UnityWebRequest.Result.ConnectionError` and `UnityWebRequest.Result.ProtocolError`
adding back the missing code from commit f5c546d
|
Travis seems to build using an older versions of unity (ie: 2019.x), these changes aren't necessary unless you decide to support unity 2020+. |
|
Can you use compilation conditionals to support previous versions too? e.g: https://github.com/proyecto26/RestClient/blob/develop/src/Proyecto26.RestClient/Helpers/RequestHelper.cs#L203 |
Added Compilations Conditionals as a means of backwards compatibility. proyecto26#164 (comment)
Changed lineEndings from Mac to Windows format
Should pass the CI build test now. |
|
Thanks for your help mate! |
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Dec 25, 2021
Added Compilations Conditionals as a means of backwards compatibility. #164 (comment)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 28, 2021
Added Compilations Conditionals as a means of backwards compatibility. #164 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed depricated APIs
UnityWebRequest.result.isNetworkErrorUnityWebRequest.result.isHttpErrorReplaced with
UnityWebRequest.Result.ConnectionErrorUnityWebRequest.Result.ProtocolError