New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated removeEventListener()
calls
#297
Remove deprecated removeEventListener()
calls
#297
Conversation
Thanks for your contribution mate, please let me check this ASAP! <3 |
@jdnichollsc would it be possible to merge that? Please not this is a breaking change for older RN versions. |
Hello folks, thanks for this awesome contribution, do you know if this works for previous versions of RN? Thanks for your help! |
@jdnichollsc This PR is not backwards compatible (at least not all the way to older versions), but it is possible. I've made a similar PR recently https://github.com/AgoraIO-Community/react-native-agora/pull/414/files |
@radko93 @jdnichollsc Hey guys, please check out the PR's current state after my newest commit. This should make it backwards-compatible, I think. |
I have tested your latest commit and I'm getting these errors...
|
@TheWirv hey mate, do you have any idea about those warnings? 🔝 |
No, absolutely not, sorry. :/ |
No problem, let me try and thanks for your help mate! <3 |
Is their a release plan for this patch? |
I'm creating a new Release 3.7.0, stay tuned! <3 |
PR Checklist
What is the current behavior?
For React Native's
Linking
andAppState
APIs, the deprecatedremoveEventListener()
calls had been used before.What is the new behavior?
Both
Linking.addEventListener()
andAppState.addEventListener()
return an event subscription object containing a correspondingremove()
method. They are being used inutils.js
now.Fixes/Implements/Closes #296.
No breaking changes
@jdnichollsc I am a TypeScript person and have never worked with flow before. Please check the flow types whether they are still correct.