Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export options types #324

Merged
merged 1 commit into from Jan 17, 2022

Conversation

rrebase
Copy link
Contributor

@rrebase rrebase commented Jan 17, 2022

Description

This PR export the types InAppBrowseriOSOptions, InAppBrowserAndroidOptions

Motivation

Allows typing the platform specific options separately

const inAppBrowseriOSOptions: InAppBrowseriOSOptions = 
  enableBarCollapsing: false,
};

const inAppBrowserAndroidOptions: InAppBrowserAndroidOptions = {
  forceCloseOnRedirection: false,
  showInRecents: true,
};

const inAppBrowserOptions: InAppBrowserOptions = {
  ...inAppBrowseriOSOptions,
  ...inAppBrowserAndroidOptions,
};

@jdnichollsc
Copy link
Member

Thanks for your contribution mate! <3

@jdnichollsc jdnichollsc merged commit 2616af1 into proyecto26:develop Jan 17, 2022
@jdnichollsc jdnichollsc mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants