Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readermode property #4

Merged
merged 3 commits into from Sep 22, 2018
Merged

Add readermode property #4

merged 3 commits into from Sep 22, 2018

Conversation

EQuimper
Copy link
Contributor

This is a fixed for my issue here #3

@jdnichollsc
Copy link
Member

Hi @EQuimper, thanks for your contribution! Can you modify the README to include that property from the example? On the other hand, it would be awesome if you include a Collaborators/Contributors section like this => https://github.com/proyecto26/RestClient#collaborators-
Let me know and thanks in advance,
Juan

@EQuimper
Copy link
Contributor Author

@jdnichollsc Thank you for the review, yes I just add this plus the Collaborators section like you want. Let me know if that's good enough :)

@jdnichollsc jdnichollsc merged commit 0603f3c into proyecto26:master Sep 22, 2018
phuongwd pushed a commit to phuongwd/react-native-inappbrowser that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants