fix: persist default settings #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdnichollsc
reviewed
Dec 9, 2023
| options?: InAppBrowserOptions = { | ||
| options?: InAppBrowserOptions = {} | ||
| ): Promise<BrowserResult> { | ||
| const defaults = { |
There was a problem hiding this comment.
Hello mate, thanks for your contribution!
Can you move the default settings outside this method please? and can you include the type InAppBrowserOptions for that new variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Opening an In App Browser with any configuration completely negates the defaults even if they are not overloaded.
What is the new behavior?
Opening an In App Browser now persists the defaults if they are not overloaded.
Fixes/Implements/Closes #[Issue Number].