Added EXR support #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 11, 2023 15:27
markkua
force-pushed
the
main
branch
3 times, most recently
from
df7c57d
to
bb91ca1
Compare
cr333
reviewed
Feb 20, 2024
Comment on lines
+131
to
+138
| img = pyroexr.load(rgb_path) | ||
| exrnparray = np.dstack((img.channel('R'), img.channel('G'), img.channel('B'))) | ||
| exrnparray = np.clip(exrnparray, 0, 1) | ||
| input_image = (exrnparray ** (1 / 2.2)).astype(np.float32) | ||
| input_size = (input_image.shape[1], input_image.shape[0]) | ||
| else: | ||
| input_image = Image.open(rgb_path) | ||
| input_size = input_image.size |
There was a problem hiding this comment.
Why use use OpenCV for reading EXRs?
For example:
img = cv2.imread(rgb_path, cv2.IMREAD_UNCHANGED)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
run.pynow can read EXR files and write EXR files. It creates an extra folder for saving the EXR with float32 precision, which are ready to be used in current VFX pipelines. It also clamps the input to 0-1, a more interesting approach may be to use logarithmic color space but that is shot dependant so I did not include it.