Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use user defined sdk versions #35

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Conversation

vieiralucas
Copy link
Contributor

I'm trying to use this library with SDK v28 and I was getting the following error:

* What went wrong:
Execution failed for task ':react-native-file-selector:verifyReleaseResources'.
> java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
  /Users/lucas/joga/mobile-app/node_modules/react-native-file-selector/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
  /Users/lucas/joga/mobile-app/node_modules/react-native-file-selector/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
  /Users/lucas/joga/mobile-app/node_modules/react-native-file-selector/android/build/intermediates/res/merged/release/values/values.xml:2996: error: resource android:attr/fontVariationSettings not found.
  /Users/lucas/joga/mobile-app/node_modules/react-native-file-selector/android/build/intermediates/res/merged/release/values/values.xml:2997: error: resource android:attr/ttcIndex not found.
  error: failed linking references.

I searched around and found that libraries do what I'm proposing in this PR to solve this issue.

Thanks <3

@prscX
Copy link
Owner

prscX commented Apr 10, 2019

Thanks a lot @vieiralucas for the PR and Effort.

I have merged the same.

Thanks
</ Pranav >

@prscX prscX merged commit f7e3e13 into prscX:master Apr 10, 2019
@prscX prscX self-assigned this Apr 10, 2019
@vieiralucas
Copy link
Contributor Author

That was fast!

Thank you, will you make a release to npm soon?

@vieiralucas vieiralucas deleted the patch-1 branch April 10, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants