New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moire issue disappears after power recovery. #766
Comments
@ctilley83 I have no idea really. Our first guess was maybe it was memory related, buffer overflow or some such being fixed by the recovery. Don't know where to begin with this, but PLEASE verify this if you guys can. Would like to see more than a couple people noticing improvement. |
@ff8jake What size cube did you use for the above test? I want to try it once my MK3 is done printing something else. |
@ff8jake did you try to pause and resume the print with getting the same effect on the result? |
This is very interesting, what do change after a power recovery? Will try this when I get home from work. |
I tried this morning 2 times and to my surprise, power recovery didn't trigger (no movement on power loss, and no special message on power on). |
You must pull the plug and not flick the switch |
@stahlfabrik What is the difference? Edit: I think that this is valid only if the power outage detector is placed before the switch. |
Well according to the manual it is by design that a willful switching off the power is not triggering power panic. It is how it is designed. A good choice if you ask me. |
Thanks! I only tried by using the power switch.
|
@Skywatchr I tried pause to no effect. Moire only disappears when I yank the plug. |
This is truly bizarre. Fantastically interesting but truly bizarre. Regardless, EXCELLENT find. This should definitely help track down the issue. |
Before you guys end up wearing out your power plugs/strips/rewiring things so the switch can do this: It seems there's a DEBUG option in the firmware to trigger this via the menu. I saw this get posted in Discord late last night before I hopped in bed so not sure what it entails, but we probably want to test this out and see if it clears the effect as well. If it has the same effects we can abuse it until this gets worked out in the software, if a power plug pull is actually required then this issue just got 100x more interesting. :) |
@ff8jake That will actually be very informative, because simulating a power recovery will do whatever that tries to do normally, presumably without actually resetting the board, and without cleaning up fully after whatever it did before starting the print. |
If that works we can just implement a gcode that triggers the power recovery debug option. Problem solved! 🔨 8) |
haha, hey buddy, 'sideburns' has a hammer for every problem :) |
This method didn’t make a difference in my tests. Maybe because I’m running a MeanWell PSU? |
@ctilley83: pulling the power plug ? or using the debug option ? |
@ctilley83 this only affects the moire, not the fat line issue in #602. Try a print like a 50mm single wall cube (no infill). At the default 95% flow rate and 280 E steps, the moire is pretty sharply defined. I am also using e-correct of 1.035. |
@HeySideburns ...as a temporary solution only you mean? lol. |
@MTJC Of course :) |
What values are gone after a power panic trip? I suppose mesh bed leveling is gone, perhaps also pinda temperature adjustment, and...? |
Devilhunter, afaik the pinda temp thing is calculated into the mesh bed leveling values and are not used or saved after their use during building of the mesh bed leveling. That said are you sure that power panic does not save the bed mesh/ mesh bed;-) |
After the panic trips, are you still connected to Pronterface? Then we could check. |
I bet it's the mesh leveling. |
|
I can add something interesting to the mix, but note that this I am still testing (currently). I found that firmware 3.1.1 - 143b(testing/debugging) had the opposite effect. I had no moire by default and then after power panic, moire appeared. I am working on a theory that my case may be that the default firmware (this version) has a flow rate of 95% and after power panic, it goes to 100%. So this may not be telling much, but it is interesting that it changes when power panic kicks in. It's at least one thing that can change. I will show pics when available. |
One thought I had is that once power panic is tripped, the starting code from the current file with all of the parameters is no longer present, such as relative settings, k values, etc. I would suspect that you are running the remaining code with the firmware defaults. I think there is some fruit here. We just need to find it. It would be awesome to solve this and the inconsistent extrusion many are plagued with. |
This is a much better pic I got off a piece last night showing the effect. Bottom portion has sharp moire, top portion has none. To further confuse the issue, it's only been a couple of us that have seen the power recovery affect things. I've done a lot of testing with Prusa experimental builds (like XYZ linearity correction), and it makes me wonder if power recovery is restoring a setting from eeprom that isn't normally getting applied in a normal startup. Maybe something I have hiding out in memory that most people don't. That said, it may be interesting to find a way to dump eeprom in a readable way and diff it against someone who's not seeing an effect from the power cord yank? |
Power panic doesn't store flow rate correctly. Gcode files for MK3 contains setting flow rate in start sequence. After power panic slightly different flow rate is used and that is why moire looks different. But moire can be more visible after power panic or less visible. It depends on printed object. We will fix storing flow rate in power panic asap. Thank you. |
@PavelSindler Go figure that the flow rate would change to the exact value to make moire disappear on the part I happen to test with. It's a little humiliating, but I am glad it exposed another issue that needs fixing. Thanks you guys for your work. Will leave this open to be closed by the pull. -Jake |
It has been fixed in PR #790. |
Update: If you want to discuss this with a lot of people working on the same issue: https://discord.gg/rchZGUg - we're up to like... 67 people in Discord now? Please only use this issue for information relevant towards a fix! Thanks!
Stumbled on this one, didn't want it buried in #602. While printing a test single wall cube, I had a power flicker that caused my MK3 to initiate a power recovery. After the recovery, the print continued as normal; however, the usual moire was gone completely.
To ensure this wasn't a fluke thing, I tried this again by intentionally pulling the power plug.
In the bottom half of the print, you can see sharp moire lines angling from the top right to bottom left. On the upper half of the print, you can see this is gone. It is hard to capture in an image, but if you try it in person you can definitely see the difference.
Thanks!
The text was updated successfully, but these errors were encountered: