Adjustable Linear Advance limits and thresholds #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the LA 1.5 MAX value to be configured in Configuration_adv.h. Define a customizable LA10<>15 detection threshold in function of the above limit. Clamp the result of of the LA10->15 return value to always respect the new LA_K_MAX.
Move la10c_reset into finishAndDisableStepper, which is called in both via lcd_print_stop() and indirectly via M84, saving some space. M84 is checked-for to determine a complete file, so it's a superior candidate to G80 (which some people avoid due to MBL issues).
As pointed out by @leptun, with MMUs the combination of old/new filament profiles in the same print is a likely scenario as we transition towards LA1.5. Reset the detection state also with K0.
|
I now incorporated the mode reset also during K0, effectively doing the same as PR #2623. By moving I've moved out finishAndDisableSteppers out of stepper.cpp, as it clearly doesn't belong there (it includes a call to functions in both planner and Marlin_main). |
3d-gussner
approved these changes
May 6, 2020
There was a problem hiding this comment.
Here some short tests and results.
- MMU gcode with two LA10 materials. Works as expected.✔
- Single material gcode with "new" PS profile having LA15 K value 1st and directly after that the LA10 K value. Works as expected.✔
- Print tiny cube. Works as expected.✔
- It detects the LA15 K value 1st and ignores the following LA10 K value ✔
- At the end with M84 it resets the LA10C: Linear Advance mode: UNKNOWN ✔
- Canceling a print in Octoprint also resets the LA to Unknown. Works as expected.✔
- Testing LA K values close to 10 shows that the #PR is working as expected. ✔
DRracer
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #2627, we rename and add some constants to avoid hard-coding limits in several parts of the code. This PR also decouples the LA1.5 maximum value from the detection threshold, although it's now simply defined in terms of the first, matching existing behavior.
We also clamp the result of
la10c_convert()to respectLA_K_MAXwhich would otherwise could be exceeded by a large LA10 value.The mode detection is also reset when stopping a print, which is a perfectly safe thing to do (taking parts of PR #2623).
PFW-1113