PFW-1499 TM: PTC model support (3.12) #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose TEMP_MODEL_fS and TEMP_MODEL_LAG as D and L respectively, initializing the default values based on the previous hard-coded values. - Always round L to the effective sample lag to future-proof model upgrades or changes (the stored value _is_ the effective value). - Introduce UV as a new linear term for PTC heaters, defaulting to an identity for model backward-compatibility.
Model UV as power-invariant, so that scaling P doesn't change the intercept location (that is, the zero point remains at the same temperature even for more powerful heaters). NOTE: It's not clear to me whether this is generally true (couldn't find a datasheet from the same heater in diffent power variants showing the efficiency loss)
Save about 20 bytes by rewriting the sample count check
Introduce a model version. This is initialized at "1" and doesn't require any upgrade/downgrade checks since it's currently retro-compatible.
Preparation to support multiple default model parameter sets
3d-gussner
changed the title
3d-gussner
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3957 for 3.12