Skip to content

Commit

Permalink
Fix of Improve Support material adhesion by base type interface layers
Browse files Browse the repository at this point in the history
under soluble supports. #5823
Implemented as a pull request #5903 by @spiky2021
and reworked.

commit c7993e6
Author: spiky2021 <77010315+spiky2021@users.noreply.github.com>
Date:   Thu Feb 11 12:39:25 2021 +0100

    Base type interfaces for soluble interface supports

    At the moment soluble support material adhesion is weak due to sparse support layers under soluble support layers. I reported as issue #5823 with pictures, as well.
    I modified two methods to the SupportMaterial Class including their headers.
    The new methods add two base type interface layers to the support structure, in case the extruders are different and soluble support is choosen.
    Since it is conditionally activated, it in general doesn't need a GUI input. But a GUI option number of base interface layers may enabled users to adapt this feature to their needs.
    This is my second try to provide a pull request on this topic. Reset my fromer repository, because first I merged this and all other changes to my master and couldn't provide separate pull request anymore.
  • Loading branch information
bubnikv committed Feb 15, 2021
1 parent b166bd7 commit 32db22b
Show file tree
Hide file tree
Showing 3 changed files with 181 additions and 76 deletions.
4 changes: 2 additions & 2 deletions src/libslic3r/Format/3mf.cpp
Expand Up @@ -710,7 +710,7 @@ namespace Slic3r {
#endif // ENABLE_RELOAD_FROM_DISK_FOR_3MF

for (const IdToModelObjectMap::value_type& object : m_objects) {
if (object.second >= m_model->objects.size()) {
if (object.second >= int(m_model->objects.size())) {
add_error("Unable to find object");
return false;
}
Expand Down Expand Up @@ -1395,7 +1395,7 @@ namespace Slic3r {
{
// deletes all non-built or non-instanced objects
for (const IdToModelObjectMap::value_type& object : m_objects) {
if (object.second >= m_model->objects.size()) {
if (object.second >= int(m_model->objects.size())) {
add_error("Unable to find object");
return false;
}
Expand Down

0 comments on commit 32db22b

Please sign in to comment.