Print time estimate incorrect for Smoothie flavor with M203

[CapnBry]

Version

1.41.1 beta and 1.41.0 release

Operating system type + version

Windows 10 Pro x64

Behavior

Print time estimates when using the Smoothie gcode flavor were much higher than expected, reporting 3h+ for a part that would only take 20 minutes to print. The reason is because Smoothieware interprets M203 parameters as mm/sec as Marlin does (reference). If the gcode includes an M203, the max feedrates are 60x too slow and therefore create too large of a print estimate.

Solution: GCodeTimeEstimator.cpp although subject to style

-float factor = (dialect == gcfMarlin) ? 1.0f : MMMIN_TO_MMSEC;
+float factor = (dialect == gcfMarlin || dialect == gcfSmoothie) ? 1.0f : MMMIN_TO_MMSEC;

Attempted workarounds: Switching to the Marlin flavor provides the correct estimate, but due to the 1.41 Machine Limits adding the jerk settings to the gcode, this gcode can not be used on Smoothieware because M205 Xnnn in smoothie sets the junction deviation, not the X jerk, so smoothie will try to run at infinite "jerk". Setting the machine limit X jerk to a reasonable deviation value in Slic3r ruins the print time estimate, due to it interpreting it as a very low jerk value.

STL/Config (.ZIP) where problem occurs

Include the following line in "Start Gcode" and switch between Marlin flavor vs Smoothie flavor. Both should have similar print time estimates.

M203 X250 Y250 Z10 E50 V15 ; max feedrate

[lf-]

Please pull request this, it sounds like you've got the exact issue figured out, and it could get fixed really quickly.

[bubnikv]

Merged. Thanks for help. Closing.