New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slic3r does not notify users of post processing script errors #1908
Comments
and if slic3r showed the log collected from the post processing script in
that case.
By the way, what return code shall be considered an error? Negative for
Linux / OSX, non-zero for Windows?
On Windows, the return code is an unsigned 32bit int
https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-getexitcodeprocess
…On Tue, Mar 5, 2019 at 10:34 PM Erik Bjorgan ***@***.***> wrote:
ALL versions, all OS's
It would be nice if Slic3r communicated when post processing scripts
failed. Ideally slic3r would display the exit condition set by the script.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1908>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFj5IzlhY4KJAI_RKDHFhx8s9jjcNOQjks5vTuLQgaJpZM4bfi9A>
.
|
… On Wed, Mar 6, 2019 at 8:47 AM bubnikv ***@***.***> wrote:
and if slic3r showed the log collected from the post processing script in
that case.
By the way, what return code shall be considered an error? Negative for
Linux / OSX, non-zero for Windows?
On Windows, the return code is an unsigned 32bit int
https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-getexitcodeprocess
On Tue, Mar 5, 2019 at 10:34 PM Erik Bjorgan ***@***.***>
wrote:
> ALL versions, all OS's
> It would be nice if Slic3r communicated when post processing scripts
> failed. Ideally slic3r would display the exit condition set by the script.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1908>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFj5IzlhY4KJAI_RKDHFhx8s9jjcNOQjks5vTuLQgaJpZM4bfi9A>
> .
>
|
vojtechkral
added a commit
that referenced
this issue
Mar 11, 2019
escape gcode path, collect stderr
vojtechkral
added a commit
that referenced
this issue
Mar 11, 2019
escape gcode path, collect stderr
vojtechkral
added a commit
that referenced
this issue
Mar 12, 2019
escape gcode path, collect stderr
Implemented for Linux / OSX by @vojtechkral , this will be part of the beta. |
Excellent! Thank you for looking at this! |
It is supposed to be implemented long time ago. closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ALL versions, all OS's
It would be nice if Slic3r communicated when post processing scripts failed. Ideally slic3r would display the exit condition set by the script.
The text was updated successfully, but these errors were encountered: