Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object disappears when wipe to object turned on #3637

Closed
Diterex opened this issue Feb 10, 2020 · 3 comments
Closed

Object disappears when wipe to object turned on #3637

Diterex opened this issue Feb 10, 2020 · 3 comments

Comments

@Diterex
Copy link

Diterex commented Feb 10, 2020

Version

PrusaSlicer 2.2.0-alpha4

Operating system type + version

Windows 10.0.183363 Build 18363

3D printer brand / version + firmware version (if known)

Prusa MK3S MMU2S FIRMWARE 3.8.1 (1.0.6)

Behavior

When trying to slice with alpha4, if wipe to object is enabled then the object disappears from the build plate. Screenshots have been included.

MMU2S issue alpha4.zip
@bubnikv
Copy link
Collaborator

bubnikv commented Feb 10, 2020

Thanks for the report. It is a regression in regard to 2.1.1.

The "wipe into object" feature is broken. If there is no wipe at a given layer, the layer is not printed at all in 2.2.0-alpha4.

bubnikv added a commit that referenced this issue Feb 10, 2020
@bubnikv
Hot fix of Object disappears when wipe to object turned on #3637
53bfb6b 
which is a regression of an optimization 3e0690b

With the optimization disabled, the G-code generator will not be slower
than PrusaSlicer 2.1.1. I am leaving the code there to mark for
further optimization opportunities.
@bubnikv
Copy link
Collaborator

bubnikv commented Feb 10, 2020

Fixed with 53bfb6b

This bug is a regression of an optimization 3e0690b

With the optimization disabled, the G-code generator will not be slower
than PrusaSlicer 2.1.1, we can optimize the code in PrusaSlicer 2.3.

The fix will be part of the next alpha (or better, hopefully the next beta).
Thanks for heads up.
Closing.

@bubnikv bubnikv closed this as completed Feb 10, 2020
bubnikv added a commit that referenced this issue Feb 10, 2020
@bubnikv
Follow up on the hot fix of #3637 53bfb6b
bfbf3ac 
This is the correct solution, which maintains the optimization introduced
by 3e0690b
@bubnikv
Copy link
Collaborator

bubnikv commented Feb 22, 2020 •
edited

The optimization was reverted & fixed with bfbf3ac

One more bug due to the optimization was fixed with 29086aa
(Due to refactoring of G-code export some "don't care" extrusions were not extruded at all.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bubnikv @Diterex