Move the "About" menu item to the application menu on macOS #10591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
approved these changes
May 16, 2023
|
@kocikdav @YuSanka @lukasmatena I see that you all modified this file recently. Would you be willing to review this change? |
iammattcoleman
force-pushed
the
macos_application_menu
branch
from
8191d2c
to
bd27240
Compare
|
The last push was just rebasing on master. There weren't any changes in my commits. |
iammattcoleman
force-pushed
the
macos_application_menu
branch
from
bd27240
to
2fb0737
Compare
|
Thanks for your contribution. |
|
Implemented in PrusaSlicer 2.7.0-alpha1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that the "About PrusaSlicer" menu item is in the Help menu when running PrusaSlicer on macOS. While that's the normal place to find an "About" menu item on Windows and Linux, macOS applications usually have it in the application menu.
This pull request moves it from the Help menu, as it is now...
...to the application menu, where Mac users expect it to be found: