Fix build with Boost 1.77 (missing include) #6849
Conversation
We're relying on boost::geometry so we need to include the "main" header for it. Fixes errors like: error: ‘boost::geometry::strategy::disjoint’ has not been declared Bug: https://bugs.gentoo.org/808771
|
Actually, I need to check if this is really a problem elsewhere first. |
|
What did you end up finding? This PR fixes build issues in Alpine Linux. |
Boost was broken internally (which you seem to have spotted). Your options are to apply the patches or upgrade Boost. Of course, you can apply this patch, but there'll be other stuff which ends up breaking even when it's including things which ought to work. My recollection is that for this bug, the patch really shouldn't have been needed, and it was just papering over the internal Boost issue (which then got fixed). (I don't love patching Boost either, but IMO it is what it is, and regressions happen. It's just a consequence of how Boost is laid out and organised.) |
|
The author of the PR for the Alpine package tried the patches referenced in the Gentoo issue without any luck. I don't know if we got all of them or not though. We'll probably just need to upgrade boost for it to work. |
Honestly, I'd do that -- Boost 1.77 was not a vintage release. But if you do want to try, it looks like you got the math patch, but not the geometry one (which was so large we had to download it): https://dev.gentoo.org/~sam/distfiles/dev-libs/boost/boost-1.77.0-patches-1.tar.xz. IIRC Boost 1.78 was much better & rather uneventful and we only had to throw in one additional patch to fix musl: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/boost/files/boost-1.78.0-interprocess-musl-include.patch. And within that: you want |
|
@thesamesam would you mind opening an mr in alpine against main/boost adding the required patches to fix 1.77? i can't seem to understand the full list of the ones you say specifically are needed (unless it's just boost-1.77-geometry.patch + boost-1.77-math-deprecated-include.patch from the patches tarball) |
|
(and if it is just those, then it's https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/34353 , but it would help me if you can confirm :) ) |
|
@nekopsykose Yes, those are the only ones he was referring to. |
We're relying on boost::geometry so we need to include the "main"
header for it.
Fixes errors like:
error: ‘boost::geometry::strategy::disjoint’ has not been declared
Bug: https://bugs.gentoo.org/808771