New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated use of M107 for RepRapFirmware #7537
base: master
Are you sure you want to change the base?
Conversation
According to [RepRapFirmware's documentation for M107](https://docs.duet3d.com/en/User_manual/Reference/Gcodes#m107-fan-off), its usage is deprecated and should be replaced by M107.
*should be replaced with M106 S0 ;) |
Fixed description of the PR. Code already did the right thing :) |
I am a little bit uneasy to merge it now just before the release. |
The current code for handling M107 has been added some 5 years now (git blame) so I doubt we will break a lot. Nonetheless, I understand the hesitation of merging this before the release 👍 |
RRF enhancements are always welcomed, thank you! We can wait in exchange of 2.4 ;) |
This issue still persists in prusaslicer 2.5.0, and is causing issues with a duet3 with duet toolboard1LC. The inclusion of M107 in the print file causes issues with the hotend cooling fan, and lowers the RPM of said fan when the file is run. Running the same file with M107 commented out causes no RPM changes of the hotend cooling fan when the file is run. |
I've also noticed a couple of days ago that this PR is still open. Any chance this might be merged and included in the next release? |
This actually needs to be fixed immediately, seeing as it can cause catastrophic failures due to promoting heat creep in the hotend, or into the direct drive extruder. I'm now manually editing M107 out of all the gcode prusaslicer spits out. There really shouldn't be any non-editable start/end gcode in the slicer. Not sure why it is set up this way, but seems very detrimental. |
Can we get some feedback when if and when this PR will be merged? |
According to RepRapFirmware's documentation for M107, its usage is deprecated and should be replaced by M106 S0.
This is also reported as #5600.