Defining a method that has the same name as a command breaks the command

[kyrylo]

I tested this on the ls command. Broken.

[1] pry(main)> def ls
             |   :wqeqw
             | end  
=> :ls
[2] pry(main)> ls
NoMethodError: undefined method `ceiling' for :wqeqw:Symbol
from /home/kyrylo/.gem/ruby/2.2.0/gems/pry-0.10.1/lib/pry/commands/ls/methods.rb:50:in `below_ceiling'

However, if you do the same with, say, the whereami command, it works well.

[egwspiti]

[1] pry(main)> def ls ; 5 ; end
=> :ls
[2] pry(main)> _pry_.config.ls
=> 5

_pry_.config, being an instance of Pry::Config, uses #method_missing to traverse a chain of parents in order to locate 'ls' key and then install a method for it. However, having 'ls' defined on Object prevents #method_missing from being called. This is further exemplified by noticing the following behavior:

[1] pry(main)> class X ; end
=> nil
[2] pry(main)> ls X
Object.methods: yaml_tag
[3] pry(main)> def ls ; 5; end
=> :ls
[4] pry(main)> ls X
Object.methods: yaml_tag
[5] pry(main)> 

We can see that using the ls command before defining an #ls method on Object doesn't break ls command when we use it afterwards.

Thus the only way to solve this bug is to redesign Pry::Config to not rely on #method_missing.

[kyrylo]

@strcmp is a Pry::Config veteran. Let him speak.