Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pry -f can no longer suppress the loading of .pryrc #1761

Closed
epitron opened this issue Jul 3, 2018 · 1 comment
Closed

pry -f can no longer suppress the loading of .pryrc #1761

epitron opened this issue Jul 3, 2018 · 1 comment
Labels
regression
Milestone
v0.12.0

Comments

@epitron
Copy link
Member

epitron commented Jul 3, 2018

https://asciinema.org/a/mongDyFR6UkDIXBPuMDbvcif1
@arlandism
Copy link
Contributor

I investigated this a bit and it looks like it's because initial_session_setup loads the .pryrc files before the option processors have run and set the configuration flags.

The simplest thing would be to reorder those things, but I'm guessing there may be state-setup reasons that wouldn't work.

@kyrylo kyrylo added this to the v0.12.0 milestone Oct 15, 2018
kyrylo added a commit that referenced this issue Oct 21, 2018
@kyrylo
cli: fix -f not suppressing load of pryrc
99455ad 
Fixes #1761 (`pry -f` can no longer suppress the loading of .pryrc)

If I recall correctly, we split session loading in #1393 because of `Pry.start`.
This broke `-f`. I think we can get away with a simple reorder in #parse_options
@kyrylo kyrylo mentioned this issue Oct 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
3 participants
@epitron @kyrylo @arlandism