Fix for Rubinius #1281
Merged
Fix for Rubinius #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- Currently, CI is failing b/c singleton_class? was added to MRI2.1 but not Rbx. e.g. https://travis-ci.org/pry/pry/builds/32133642 However, I did not look into why it is suddenly failing now. For quite a while, Rbx builds were erroring out (e.g. https://travis-ci.org/pry/pry/jobs/30421343) They are no longer failing, but are now erroring, for the above reason. Context ------- Rbx has recently (11 days ago, 30 July 2014) received this method rubinius/rubinius@2e71722 But the functionality has been available since April 2011 rubinius/rubinius@4310f6b Solution -------- Fix the failures by falling back to the older functionality if we are on Rubinius, and the new method is unavailable.
JoshCheek
added a commit
to JoshCheek/pry
that referenced
this pull request
Aug 10, 2014
Removes Bacon and Mocha
Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)
The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block. In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
This will fail on master until pry#1281 is merged.
This makes pry#1278 unnecessary.
JoshCheek
added a commit
to JoshCheek/pry
that referenced
this pull request
Aug 10, 2014
Removes Bacon and Mocha Reasoning explained in this comment: pry#277 (comment) Mostly this went smoothly. There were a few errors that I fixed along the way, e.g. tests that were failing but for various reasons still passed. Should have documented them, but didn't think about it until very near the end. But generaly, I remember 2 reasons this would happen: `lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass because the second argument is ignored by Bacon. And `1.should == 2` will return false instead of raising an error when it is not in an it block (e.g. if stuck in a describe block, that would just return false) The only one that I felt unsure about was spec/helpers/table_spec.rb `Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'` This is wrong, but was not failing because it was in a describe block instead of an it block. In reality, it returns `"head: ing\n"`, I updated the test to reflect this, though I don't know for sure this is the right thing to do This will fail on master until pry#1281 is merged. This makes pry#1278 unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, CI is failing b/c singleton_class? was added to MRI2.1 but not Rbx. e.g. https://travis-ci.org/pry/pry/builds/32133642
I did not look into why it is suddenly failing now. For quite a while, Rbx builds were erroring out (e.g. https://travis-ci.org/pry/pry/jobs/30421343) They are no longer erroring, but are now failing, for the above reason.
Context
Rbx has recently (11 days ago, 30 July 2014) received this method rubinius/rubinius@2e71722
But the functionality has been available since April 2011 rubinius/rubinius@4310f6b
Solution
Fix the failures by falling back to the older functionality if we are on Rubinius, and the new method is unavailable.