support custom implementation of BasicObject#inspect. #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rf- might as well leave this open for a while. i'll add some tests. |
0x1eef
force-pushed
the
basicobj-inspect
branch
from
cb7f74f
to
c838d2e
Compare
added 5 commits
January 13, 2015 19:44
If BasicObject or a subclass of BasicObject implements #inspect, we will try to use its return value as output but if that fails, we'll fallback on __id__. fixes #1341
0x1eef
force-pushed
the
basicobj-inspect
branch
from
105179f
to
e4aa4da
Compare
|
Looks good, thanks Rob. |
|
@rf- No problem. It looks like you accepted but didn't click "merge", & I couldn't find the commits on master. i merged the branch and pushed to master for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If BasicObject or a subclass of BasicObject implements #inspect,
we will try to use its return value as output but if that fails,
we'll fallback on id.
fixes #1341