#27

we can’t easily detect if a page is loading from the browser history buttons, so opt to not keep the cached values of selects
pryley · Aug 14, 2018 · be39832 · be39832
1 parent 6dcf585
commit be39832
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/float-labels.js b/src/float-labels.js
@@ -307,8 +307,10 @@
 		setSelectPlaceholder: function( el, placeholderText ) {
 			var childEl = el.firstElementChild;
 			if( childEl.hasAttribute( 'value' ) && childEl.value ) {
-				var selected = el.options[Math.max( 0, el.selectedIndex )].defaultSelected !== true ? true : false;
-				el.insertBefore( new Option( placeholderText, '', selected, selected ), childEl );
+				el.insertBefore( new Option( placeholderText, '' ), childEl );
+				if( el.options[el.selectedIndex].defaultSelected === false ) {
+					el.selectedIndex = 0;
+				}
 			}
 			else {
 				childEl.setAttribute( 'value', '' );